Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Date Modified on Articles Manager (new feature) #15825

Merged
merged 1 commit into from
May 22, 2017

Conversation

joomlabeat
Copy link
Contributor

@joomlabeat joomlabeat commented May 5, 2017

Adding Date Modified sorting for Articles Manager in backend

Pull Request for Issue #15610

Summary of Changes

4 files modified

  1. Including Date Modified field in the model
    administrator/components/com_content/models/articles.php

  2. Adding the option in the ordering list form field with language constant.
    administrator/components/com_content/models/forms/filter_articles.xml

  3. Modifying the tmpl file, to consider the new date ordering label on the table's headings.
    administrator/components/com_content/views/articles/tmpl/default.php

  4. Adding en-GB translations for the new constants
    administrator/language/en-GB/en-GB.com_content.ini
    Totally 3 new constants:
    COM_CONTENT_HEADING_DATE_MODIFIED="Date Modified"
    COM_CONTENT_MODIFIED_ASC="Date Modified ascending"
    COM_CONTENT_MODIFIED_DESC="Date Modified descending"

Testing Instructions

After applying the patch, go in articles manager in backend and through the Sorting List select the Date Modified ASC/DESC options to sort articles by date modified.

Expected result

The articles should be ordered by this date option.

Documentation Changes Required

Mention that articles manager now supports ordering the articles by Date Modified using the Sorting List field.

Adding Date Modified sorting for Articles Manager
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels May 5, 2017
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on bb17ce3

As this is implemented in the same way as the other date modifiers that are not displayed in the columns by default this is fine by me.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15825.

@@ -110,6 +110,8 @@
<option value="language DESC">JGRID_HEADING_LANGUAGE_DESC</option>
<option value="a.created ASC">JDATE_ASC</option>
<option value="a.created DESC">JDATE_DESC</option>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tab alignment.

@@ -161,6 +162,8 @@ COM_CONTENT_PAGEBREAK_DOC_TITLE="Page Break"
COM_CONTENT_PAGEBREAK_INSERT_BUTTON="Insert Page Break"
COM_CONTENT_PAGEBREAK_TITLE="Page Title:"
COM_CONTENT_PAGEBREAK_TOC="Table of Contents Alias:"
COM_CONTENT_MODIFIED_ASC="Date Modified ascending"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetize/move strings.

@ghazal
Copy link
Contributor

ghazal commented May 8, 2017

I have tested this item ✅ successfully on bb17ce3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15825.

@joomla-cms-bot joomla-cms-bot removed Language Change This is for Translators PR-staging labels May 8, 2017
@ghost
Copy link

ghost commented May 8, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 8, 2017
@rdeutz rdeutz added this to the Joomla 3.7.2 milestone May 9, 2017
@rdeutz rdeutz modified the milestones: Joomla 3.7.2, Joomla 3.7.3 May 18, 2017
@rdeutz rdeutz merged commit 7be56df into joomla:staging May 22, 2017
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators and removed RTC This Pull Request is Ready To Commit labels May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants